Journal Entry - Week 3 (CST 338)

Code review:


  1. Tim Shaker

    1. The variable names are clear in my opinion. I can immediately tell if a variable is likely a boolean, string, or holding a number. The logic seems efficient, though I think that Tim should consider using an enhanced for loop especially in makeGuess where he could shave a few lines of code. The formatting is good with good use of indentations and his comments are good. I wish that Tim would consider placing comments throughout the method instead of in one chunk.

  2. Glenn Bale Carreon

    1. The variable names are easy to follow and follow the camel case format. I like that Glenn used good logic, however, I wished that he removed the todo comments or marked them as finished once completed. One recommendation would be to simplify the hasLost() method to use the getRemainingGuesses() method. Glenn’s comments are good but a bit simply and usually in a chunk rather than inside the methods themselves. 

My feedback:


My teammates have offered limited but helpful feedback on my code. Tim told me that while my code was great and functional, I could’ve condensed it a bit especially in makeGuess(). Overall, I received mostly good feedback.


Trends I noticed:


One trend that I noticed after reviewing Tim and Glenn’s code is the varying complexity of readFile(). I noticed that our logic differed a bit. With mine, I put the while loop inside the try statement while Glenn for example put his while loop after the try statement. While both are good approaches, it was one difference that stood out to me.


Answers to the following:


  1. What improvements would you make to your code/what was suggested? I would try to simplify my code. For example, I would remove the else statement in exit() as I didn’t need it.

  2. Which unit tests were the hardest to pass? For me, the hardest unit test to pass was Gameloader.

  3. How do the existing tests function and could they be improved? To my knowledge, the existing test functions use asserts and error handling among other techniques to test the code in Hangman. 

    1. Do the existing unit tests cover the full range of the sub classes? No, HangmanTest.java doesn’t cover the getScore() or getCountWordsRemaining() for example.

    2. How would you change the unit tests? I would make sure that the unit test will test every method in Hangman.java.

      1. Keep in mind I do not want them to change but this doesn't mean I think they are perfect.  Reading through the tests is a good way to learn what the code should do thinking about how to test the codeis a good way to learn how to make tests.

  4. What did you struggle with? I struggled with makeGuess() the most as it was the most complex in my opinion.

  5. What did one of your teammates struggle with? I would say they also struggled with makeGuess() too.

  6. Was any part of the code a struggle for YOU? Yes, I would say that coding makeGuess() was a struggle for me.

  7. Was any part of writing the code easy for YOU? Yes, some of the methods that return simple booleans and variables were easy for me.

  8. What was your biggest HW1 victory? For me, my biggest HW1 victory was submitting it a day early. While not a coding achievement directly, it marked an important pivot for me to not procrastinate.



Comments

Post a Comment

Popular posts from this blog

Journal Entry - Week 4

  Part One: Set Your Education Goals My education goal that I envision myself achieving is to turn in all my assignments by Monday, midnight. This goal signifies a lot as it would mean that I would have a ‘day off’ essentially on Tuesday when all assignments are due for CST 300 and CST 349. I feel driven to achieve this goal as it would reduce my stress and give me a day off on a weekday. In terms of attaining it, I would say that I am close. Last week, I submitted my essay for CST 300 at around noon on Tuesday. I had completed all my assignments except the essay before Tuesday. Overall, I think this goal is easy to attain and impactful. Part Two: Set Your Career Goals My career goal is to become a senior software engineer at a technology company. I think that this goal is vivid as it is tangible – an official title given by an employer. I feel excited to achieve this as it’ll allow me to make a bigger impact in producing high quality software and work with a team of skilled engine...
Read more

Journal Entry - Week 2

Image
After reading the document titled “Effective Study Skills”, I have deducted that I am good at (1) getting the main idea of a reading or module, (2) asking questions about the content rather than just accepting it as is, and (3) when studying, to periodically stop and recite what I’ve read thus far. I feel that I could improve on (1) having a schedule and plan for studying rather than just starting/ending based on personal sentiment, (2) reviewing notes immediately after a lecture, and (3) not studying for more than 30–40 minutes at a time. The presentations in part 3 taught me about how projects are professionally operated and managed. The introduction defined a project as a temporary endeavor with a unique output. It also talked about how the market, regulations, and other business aspects constitute triggers for launching projects. The introduction also spoke about the project manager, the person in charge of a project but also accountable for its performance. Meanwhile, the WBS ...
Read more

Journal Entry - Week 5

Image
  Part One: Support and Comment on Teammates' Goals Links and screenshots are provided.  URL 1: https://edlcsonline.blogspot.com/2025/09/week-4-learning-journal-education-goals.html?sc=1759431294592#c8334417531238256030 URL 2: https://alexandercsumb.blogspot.com/2025/09/my-educational-goal-in-cs-program-my.html?sc=1759430980864#c8207554112685803038 Part Two: Possible Capstone Ideas There are 3 possible Capstone projects that I may pursue. Firstly, a bird’s song interested me as it was a game which encompassed a wide variety of CS topics such as graphics, physics, and error handling. Secondly, the project where someone identified brain tumors using computer vision is very intriguing to me as that project used Google’s GPUs in their cloud computing to train their computer vision model. This project also helps the world which is good. Thirdly, the town hub project might also be one that I may consider as that project involves a GUI and a lot of components which would be a great e...
Read more